Improve live stream startup behavior with preroll #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, if a live (
LINEAR
orDVRLIVE
) stream was started with a pre-roll ad, playback started but the ad break information would come late. This led to situations where the non-ads UI was visible for some time before switching to the ads UI during ads playback.The integration is now following the guidelines from https://developer.yospace.com/sdk-documentation/javascript/userguide/yosdk/latest/en/optimising-user-experience-at-video-start.html to improve this behavior. The
SourceLoaded
will only be triggered and theload
Promise will only resolve once the Yospace SDK received and propagated the ad information update.Also fixed the missing pass-through of the
issuer
parameter for some methods to the events, namelymute
(Muted
event),unmute
(Unmuted
event) andpause
(Paused
event).Checklist (for PR submitter and reviewers)
CHANGELOG
entry