Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve live stream startup behavior with preroll #183

Merged
merged 10 commits into from
Dec 5, 2024

Conversation

dweinber
Copy link
Member

@dweinber dweinber commented Dec 4, 2024

Description

Previously, if a live (LINEAR or DVRLIVE) stream was started with a pre-roll ad, playback started but the ad break information would come late. This led to situations where the non-ads UI was visible for some time before switching to the ads UI during ads playback.

The integration is now following the guidelines from https://developer.yospace.com/sdk-documentation/javascript/userguide/yosdk/latest/en/optimising-user-experience-at-video-start.html to improve this behavior. The SourceLoaded will only be triggered and the load Promise will only resolve once the Yospace SDK received and propagated the ad information update.

Also fixed the missing pass-through of the issuer parameter for some methods to the events, namely mute (Muted event), unmute (Unmuted event) and pause (Paused event).

Checklist (for PR submitter and reviewers)

  • CHANGELOG entry

@dweinber dweinber requested a review from stonko1994 December 4, 2024 08:36
src/ts/InternalBitmovinYospacePlayer.ts Outdated Show resolved Hide resolved
src/ts/InternalBitmovinYospacePlayer.ts Outdated Show resolved Hide resolved
src/ts/YospaceListenerAdapter.ts Show resolved Hide resolved
src/ts/YospaceListenerAdapter.ts Show resolved Hide resolved
@dweinber dweinber merged commit cfcfead into main Dec 5, 2024
3 checks passed
@dweinber dweinber deleted the feature/improve-startup-with-preroll branch December 5, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants